Skip to content

Remove PPEs - use calcMeanMaxSuggested #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2025
Merged

Remove PPEs - use calcMeanMaxSuggested #1885

merged 2 commits into from
Oct 14, 2025

Conversation

Affie
Copy link
Member

@Affie Affie commented Oct 9, 2025 •
edited
Loading

This removes PPEs that will be obsolete in DFG v0.29 (marked as deprecated in v0.28). The next IIF can then deal with the struct breaking changes introduced in v0.29

@Affie Affie added this to the v0.36.0 milestone Oct 9, 2025
@Affie Affie self-assigned this Oct 9, 2025
@Affie Affie requested a review from dehann October 13, 2025 18:41
@codecov Codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@fbeecf7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
IncrementalInference/src/Deprecated.jl 0.00% 45 Missing ⚠️
IncrementalInference/src/services/FGOSUtils.jl 0.00% 6 Missing ⚠️
...ference/src/parametric/services/ParametricUtils.jl 0.00% 1 Missing ⚠️
IncrementalInference/src/services/TetherUtils.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             develop   #1885   +/-   ##
=========================================
  Coverage           ?   0.00%           
=========================================
  Files              ?      68           
  Lines              ?    5552           
  Branches           ?       0           
=========================================
  Hits               ?       0           
  Misses             ?    5552           
  Partials           ?       0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dehann
dehann requested changes Oct 13, 2025
View reviewed changes
Copy link
Member

@dehann dehann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except for _checkVariablesByReference?

dehann
dehann approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@dehann dehann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, TODO broken seem like a better path. It's indicated by underscore as internal -- don't think it's exported. I'm happy to merge as is.

@Affie Affie merged commit 9c1ecf5 into develop Oct 14, 2025
3 of 5 checks passed
@Affie Affie deleted the rm_ppes branch October 14, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dehann dehann dehann approved these changes

Assignees

@Affie Affie

Labels

breaking changes deprecation PPE

Projects

None yet

Milestone

v0.36.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Affie @dehann